This repository was archived by the owner on May 3, 2018. It is now read-only.
rename PartestTask to SbtPartestTask and bump versions #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PartestTask` is a very unfortunate name for this, because it already exists in scala-partest; there is: - `scala.tools.partest.PartestTask extends org.apache.tools.ant.Task` in scala-partest, for running partest with ant - `scala.tools.partest.PartestTask extends sbt.testing.Task` for running partest with sbt Depending on the order `scala-partest` and `scala-partest-interface` are added to the dependencies, SBT can get the wrong one and crash...
gourlaysama
force-pushed
the
wip/partest-task
branch
from
8461056 to
4994667
Compare
|
LGTM Good stuff! |
gkossakowski
added a commit
that referenced
this pull request
Oct 17, 2014
rename PartestTask to SbtPartestTask and bump versions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking into building Scala with SBT recently (poke @gkossakowski), and stumbled upon this.
PartestTaskis a very unfortunate name for this, because it alreadyexists in scala-partest; there is:
scala.tools.partest.PartestTask extends org.apache.tools.ant.Taskin scala-partest, for running partest with ant,
scala.tools.partest.PartestTask extends sbt.testing.Taskforrunning partest with sbt.
Depending on the order
scala-partestandscala-partest-interfaceareadded to the dependencies, SBT can get the wrong one and crash...
The second commit bumps version numbers (the last release was 0.4.0).